fix ameba suggestions

Author: KCErb

spec/mirror_spec.cr

@@ -19,17 +19,13 @@ module Symm32
     end
 
     it "mirror acts on vectorlike" do
-      vec = Vector3.new(1, 1, 1)
-      point = ChiralPoint.new(vec)
       res = m.transform({1, 1, 1})
       res[0].should be_close(-1, 2*Float64::EPSILON)
       res[1].should be_close(-1, 2*Float64::EPSILON)
       res[2].should be_close(-1, 2*Float64::EPSILON)
     end
 
     it "mirror inverts if vectorlike is 'chiral'" do
-      vec = Vector3.new(1, 1, 1)
-      point = ChiralPoint.new(vec)
       res = m.transform({1, 1, 1}, [:chiral])
       res[0].should be_close(1, 2*Float64::EPSILON)
       res[1].should be_close(1, 2*Float64::EPSILON)

spec/point_group_spec.cr

@@ -32,7 +32,7 @@ module Symm32
       end
 
       it "selects directions given axes and sorts by enum" do
-        axes = [Axis::D1, Axis::Z, Axis::Origin]
+        axes = [Axis::D1, Axis::Z, Axis::ORIGIN]
         pg2m.select_directions(axes).first.axis.should eq Axis::Z
       end
 

spec/point_isometry_spec.cr

@@ -20,7 +20,7 @@ module Symm32
 
     it "is not created from an invalid string (general)" do
       expect_raises(ArgumentError) do
-        iso = PointIsometry.parse("foos")
+        PointIsometry.parse("foos")
       end
     end
   end

src/axis.cr

@@ -13,7 +13,7 @@ module Symm32
 
   # :nodoc:
   module Axes
-    Origin = Vector3.new(0, 0, 0)
+    ORIGIN = Vector3.new(0, 0, 0)
     Z      = Vector3.new(0, 0, 1)
     # plane perpendicular to z
     T0   = Vector3.new(1, 0, 0)
@@ -59,7 +59,7 @@ module Symm32
   # is for me to try to explain it in text here.
   #
   # The names can be visualized by imagining a cube. We first designate
-  # the center of the cube as the `Origin`. All point isometries leave this point
+  # the center of the cube as the `ORIGIN`. All point isometries leave this point
   # unchanged. Next we select an axis which passes through the origin and the
   # center of a face and call this the `Z` axis.
   #
@@ -74,8 +74,8 @@ module Symm32
   # We orient this square so that the edge corresponding to the T0 face is
   # on our right and the edge corresponding to T90 is on top. There are two
   # more kinds of axes we are interested in, those which pass through the center
-  # of one of these 4 edges (as well as the `Origin`) and those which pass through
-  # one of the 4 diagonals (and the `Origin`).
+  # of one of these 4 edges (as well as the `ORIGIN`) and those which pass through
+  # one of the 4 diagonals (and the `ORIGIN`).
   #
   # The center-edge axes we'll call "edge" axes, and number them `E1`, `E2`,
   # `E3`, and `E4` with `E1` on our right (corresponding to the `T0` face), `E2`
@@ -89,7 +89,7 @@ module Symm32
   # Thus the enum is essentially this:
   # ```
   # enum Axis
-  #   Origin # => {0, 0, 0}
+  #   ORIGIN # => {0, 0, 0}
   #   Z      # => {0, 0, 1}
   #   T0     # => {1, 0, 0}
   #   T30    # => {√3/2, 1/2, 0}

src/point_group.cr

@@ -108,9 +108,9 @@ module Symm32
     end
 
     private def init_directions
-      by_axis = isometries.group_by { |iso| iso.responds_to?(:axis) ? iso.axis : Axis::Origin }
+      by_axis = isometries.group_by { |iso| iso.responds_to?(:axis) ? iso.axis : Axis::ORIGIN }
       dirs = by_axis.compact_map do |axis, iso_arr|
-        next if axis == Axis::Origin
+        next if axis == Axis::ORIGIN
         Direction.new(axis, iso_arr)
       end
       dirs.sort_by(&.axis)
@@ -162,7 +162,6 @@ module Symm32
       end
 
       # fill the table with results from the map
-      size = isometries.size
       @multiplication_table = Hash2DIsometry.new
       isometries.each do |inv_row_iso|
         row_iso = @inverses_hash[inv_row_iso]

src/point_isometry.cr

@@ -71,7 +71,7 @@ module Symm32
     private def self.parse_axis(direction, bar)
       # remove kind => mt30 => t30, -4z => z
       direction = bar ? direction[2..-1] : direction[1..-1]
-      return Axis::Origin if direction == "" # e and i have no axis
+      return Axis::ORIGIN if direction == "" # e and i have no axis
 
       dir_char = direction[0]
       return Axis::Z if dir_char == 'z'