Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

A bit of performance left on the table #4

Open
bconstanzo opened this issue Aug 26, 2022 · 2 comments
Open

A bit of performance left on the table #4

bconstanzo opened this issue Aug 26, 2022 · 2 comments

Comments

@bconstanzo
Copy link

bconstanzo commented Aug 26, 2022

This module turned out to be the main performance bottleneck on a tool I've been working on, and I found out there could be some performance left on the table. On my computer* I'm getting 20-30% improved decoding speed by adding a few cython types, though I've not managed to clean up everything just yet.

Is this project still active? I can send a pull request and if you can check if the changes hold on other OSes/versions, it could be valuable for others.

* under python 3.10 64 bit, on windows 10

@K0lb3
Copy link
Owner

K0lb3 commented Sep 5, 2022

The project isn't active anymore.
It got replaced by texture2ddecoder, which supports many other formats on top.

In case you want to stick with astc_decomp I would advise to directly write C code to wrap the C functions instead of using Cython, as it's faster this way.

@bconstanzo
Copy link
Author

Hey there! I made a fork of this and tuned the Cython code quite a bit to get that missing performance. For a project where I'm contributing there was a lot of value in keeping the API consistent and just getting the speedups. Thanks for the pointers, and your effort building this in the first place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants