Add 9j symbols. #17
Closed
Add 9j symbols. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce for very large symbols, but performed worse on all benchmarks run
minor cached binomial performance improvement. larger 9j test.
Re-implement inner 9j sum using prime factorization techniques.
improve performance of 9j inner sum by prime factorization
|
closed so I can cleanup and do more testing. made a bit of a mess optimizing the 9j inner sum. edit: submitted a separate clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've taken a rough pass at implementing the 9j symbols based on L. Wei (1998), per the README's TODO. I'm new to package-quality
julia, but tried to use mostly similar patterns to the older code - for readability and minimal impact on that existing code.Based on a bit of profiling, there's probably still some type-stability and performance to be gained, but the computation runs reasonably quickly, is exact, and tests well against the decomposition in terms of sums of products of 6j symbols.
I'd be happy to take any feedback/make any edits! :)