0006646: Setting node.offline parameter to true or false disables all

Philip Marzullo · Philip Marzullo · commit 514d06e6a2a1 · 2024-11-12T11:48:32.000-05:00
communication
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java
@@ -302,7 +302,10 @@ protected List<Node> removeOfflineNodes(List<Node> nodes) {
                     Node node = iter.next();
                     if ((parm.getNodeGroupId().equals(ParameterConstants.ALL) || parm.getNodeGroupId().equals(node.getNodeGroupId()) &&
                             (parm.getExternalId().equals(ParameterConstants.ALL) || parm.getExternalId().equals(node.getExternalId())))) {
-                        iter.remove();
+                        if (parm.getValue() != null &&
+                                Boolean.valueOf(parm.getValue())) {
+                            iter.remove();
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,10 @@ protected List<Node> removeOfflineNodes(List<Node> nodes) {`
`302`	`302`	`Node node = iter.next();`
`303`	`303`	`if ((parm.getNodeGroupId().equals(ParameterConstants.ALL) \|\| parm.getNodeGroupId().equals(node.getNodeGroupId()) &&`
`304`	`304`	`(parm.getExternalId().equals(ParameterConstants.ALL) \|\| parm.getExternalId().equals(node.getExternalId())))) {`
`305`		`- iter.remove();`
	`305`	`+ if (parm.getValue() != null &&`
	`306`	`+ Boolean.valueOf(parm.getValue())) {`
	`307`	`+ iter.remove();`
	`308`	`+ }`
`306`	`309`	`}`
`307`	`310`	`}`
`308`	`311`	`}`