Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: AddProfile Has Been Voted Off the Island #93

Open
3 tasks
sgilfeather opened this issue May 4, 2023 · 0 comments
Open
3 tasks

Task: AddProfile Has Been Voted Off the Island #93

sgilfeather opened this issue May 4, 2023 · 0 comments
Assignees
Labels
help wanted Extra help would be great!

Comments

@sgilfeather
Copy link
Contributor

🎯 due Monday, April 8th

My generically-typed modular AddProfile component is too complex and over-engineered than what we need for the Legacy Project's webpage (it was fun while it lasted, y'all). That being said, I'm nuking the old AddProfile component and transitioning to a much simpler AddSenior page that's less parameterized. This ticket is for me! (Skylar)

  • Kill your baby AddProfile and transition to using just the singular add-senior.tsx page for your profile. When mapping over the input boxes, create a separate component for the dropdown s

Right now, setProfileData only sets the value of the selectName field (event.target.name) to the new value provided (event.target.value). We want to accumulate values chosen in the dropdown, so that setProfileData adds a new value to the input box, and doesn't replace it.

  • Modify components/addProfile/form.tsx at line 31 so that it accumulates a list of values, rather than replacing them on every call of handleSelected.

Furthermore, there's a bug in the profile form where clicking on any input box causes the dropdown to pop up.

  • Fix this bug, so that the dropdown only pops up on selection of its input box. This requires refactoring the component such that this specific input box accumulates a list of Student models: displaying their names, while keeping track of their IDs so that these can be compiled into a list on submission to create the Senior model.

Screenshot 2023-04-24 at 11 18 57

@sgilfeather sgilfeather self-assigned this May 4, 2023
@sgilfeather sgilfeather added the help wanted Extra help would be great! label May 4, 2023
@sgilfeather sgilfeather changed the title Ticket: Add Senior Ticket: AddProfile Has Been Voted Off the Island May 4, 2023
@sgilfeather sgilfeather changed the title Ticket: AddProfile Has Been Voted Off the Island Task: AddProfile Has Been Voted Off the Island May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra help would be great!
Projects
None yet
Development

No branches or pull requests

1 participant