Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decode() interface accept AbstractVector #46

Open
jdonnerstag opened this issue Nov 19, 2020 · 1 comment
Open

Make decode() interface accept AbstractVector #46

jdonnerstag opened this issue Nov 19, 2020 · 1 comment

Comments

@jdonnerstag
Copy link

Hi,

we are working a lot with @view/SubArray on top of a larger buffer. Currently the decode() function requires a Vector{UInt8} argument. For us it means we need to copy the data in an inner, performance optimized, loop. In case there is no specific reason, would it possible to change the interface to support AbstractVector{UInt8}?

thanks a lot

@nalimilan
Copy link
Member

Maybe I've been overly restrictive. Can you make a PR to use AbstractVector (with tests to check that it works)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants