Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Add a tutorial about rank deficiency #114

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jan 22, 2025

@abuttari Did you rename qrm_rd_eps and qrm_rd_num since I did the Julia interface?
It seems that qr_mumps never compute the number of diagonal coefficients that are almost zero if I set a tolerance qrm_rd_eps > 0.

cc @MaxenceGollier

Preview: https://jso.dev/QRMumps.jl/previews/PR114/
Update: The preview will not work, I created the PR from my fork...

@abuttari
Copy link
Contributor

Actually due to a small bug, the number of small pivots was not correctly reported. I pushed a fix in the master branch which will be available in the next release

@amontoison
Copy link
Member Author

Thanks @abuttari !

@amontoison amontoison merged commit 48607e9 into JuliaSmoothOptimizers:main Jan 22, 2025
17 of 23 checks passed
@amontoison amontoison deleted the rank_deficient branch January 22, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants