Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need CommentBot tests #404

Open
zot opened this issue Jan 9, 2023 · 0 comments
Open

Need CommentBot tests #404

zot opened this issue Jan 9, 2023 · 0 comments

Comments

@zot
Copy link
Collaborator

zot commented Jan 9, 2023

We should add some tests for CommentBot. These should activate the full flow from browser -> GitHub -> web hook. It's possible there is a way to do this without @mock:

  • use a test GitHub repo
  • run a mock GitHub server during the test (change the url in the GitForge struct)
  • Hit GitHub live and use a webhook multiplexing service
    • zapier
    • IFTTT
  • use a mock GitForge forge

If @mock is the best way to do this, we can add mock calls to the registrator code.

@nkottary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant