You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for the case of multiple alleles.
We need to really look into the order of things, and do not repeat steps.
Make sure that some things are done inside optTopRuns.
Problem: we need to print the network before merging leaves (which is currently done outside optTopRuns), so writeTopologyLevel1 needs to merge the leaves. But merging the leaves messes with the root.
Currently, we do:
In optTopRuns:
check the root
print maxNet (with writeTopologyLevel1 which merges leaves and checks root again inside)
In snaq:
merge leaves for good before returning the network
checks the root again
The text was updated successfully, but these errors were encountered:
From @cecileanecomment:
This is unrelated to the docstring, but it would be good to include a formal test for the changes to writeTopologyLevel1 and to the end of snaq!, in 1da3325).
By the way, the chunk of code repeated in writeTopologyLevel1 and in snaq! could possibly be moved to checkRootPlace!: There would be less room for bugs (e.g. bug fixed in one place but not in the other, when the chunk is repeated), and the code for both writeTopologyLevel1 and in snaq! would be cleaner. The formal test could also be made cleaner that way.
We have a mess in the order of:
for the case of multiple alleles.
We need to really look into the order of things, and do not repeat steps.
Make sure that some things are done inside
optTopRuns
.Problem: we need to print the network before merging leaves (which is currently done outside
optTopRuns
), sowriteTopologyLevel1
needs to merge the leaves. But merging the leaves messes with the root.Currently, we do:
optTopRuns
:writeTopologyLevel1
which merges leaves and checks root again inside)snaq
:The text was updated successfully, but these errors were encountered: