Don't fetch results that are discarded#258
Merged
andreasnoack merged 4 commits intoJuliaParallel:masterfrom Dec 4, 2025
Merged
Don't fetch results that are discarded#258andreasnoack merged 4 commits intoJuliaParallel:masterfrom
andreasnoack merged 4 commits intoJuliaParallel:masterfrom
Conversation
696837b to
7906f83
Compare
7906f83 to
f6c592f
Compare
Contributor
Author
|
@andreasnoack after adding (currently missing) tests for |
andreasnoack
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #256.
Currently, on the master branch in a few places results are fetched from other nodes and/or collected with
asyncmapthat are discarded afterwards. With this PR, these results will not be fetched/collected at all.Edit: Based on the codecov report, it seems
fill!has not been tested. I added a test for it.