Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plotting to Makie #13

Open
Datseris opened this issue Apr 15, 2021 · 3 comments
Open

Move plotting to Makie #13

Datseris opened this issue Apr 15, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Datseris
Copy link
Member

With the new progress in AbstractPlotting, now in version 0.17, Makie is the premier stellar plotting library for Julia. We should port all plotting code there, which will make it 1000s of times faster as well.

Very easy to do.

@Datseris Datseris added the good first issue Good for newcomers label Apr 15, 2021
@Datseris Datseris mentioned this issue Apr 15, 2021
@NeroBlackstone
Copy link
Member

NeroBlackstone commented Apr 27, 2023

I read the original MusicVisualizations implementation and Makie documentation.
I think it's hard to implement plotpianonote! function using Makie, since there is no PyPlot "patches" counterpart in Makie. A possible Makie implementation is Ledgend. But it's a little low-level and lacks documentation.

So, maybe we should change "Piano Roll" and "Drum Map" implementation in Makie.

For the piano roll, a good solution is barplot.

For the drum map, we can use MarkerElement in Ledgend. And add an argument to indicate how to plotting drum, like Dict(1=>("kick",MarkerElement))

@Datseris
Copy link
Member Author

Hm, isn't the simplest that for PyPlot patches you use the rectangles and mesh scatter: https://docs.makie.org/stable/examples/plotting_functions/meshscatter/ ?

@Datseris
Copy link
Member Author

For drum map a simple scatter! is all we need, as in Makie scatter allows to have different marker and color per scattered data point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants