Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflows #40

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Update GitHub workflows #40

merged 1 commit into from
Apr 30, 2024

Conversation

gnadt
Copy link
Contributor

@gnadt gnadt commented Apr 29, 2024

No description provided.

os: [ubuntu-latest, windows-latest, macos-latest]
arch:
- x64
version: [1.6, 1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if this is left as only version 1. There is no reason to test two versions, latest stable Julia is more than enough. (I am very climate consicous and I believe we all should be avoiding computations that are not necessary)

@Datseris
Copy link
Member

I've invited you to JuliaMusic and added you admin rights for MusicProcessing.jl by the way.

@gnadt
Copy link
Contributor Author

gnadt commented Apr 30, 2024

Hmm I don't know about that, I think it's pretty common to test on the LTS Julia version, this CI is tiny and rarely run anyway

@Datseris
Copy link
Member

What is the particular functionality that you think really makes a difference to test on LTS? Which particular functions depend on the exact Julia version greater than 1.0? What sort of knowledge would you obtain by testing on LTS that you wouldn't obtain already by testing on latest stable?

@gnadt
Copy link
Contributor Author

gnadt commented Apr 30, 2024

Unknown unknowns

@Datseris Datseris merged commit 3662749 into JuliaMusic:master Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants