You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #28 introduced the scale_identification functionality. Currently is not yet exported because the following things must be improved / modified:
tests! The file seranade_full.mid is a recording of serenade to a cuckoo. It should be tested as well. In addition the file testmidi() is Doxy, which should also be tested.
Improve the algorithm description. Right now the function does not do as it claims. It claims to find the "most probable scale" but this is untrue. It just returns the first scale with a match of the seven notes.
Consider the return signature in case of failure. What should we return in the case that the function fails to find a scale? You cannot print from within a proper high level function. I suggest the function to simply error saying "we couldn't find a scale" and also show the 7 most frequent notes in the printed string.
sort(Dict( is deprecated, we have to re-work the code a bit to do sorting after the dict is collected (sort keys and use sort indices on values as well) .
The text was updated successfully, but these errors were encountered:
I have read relative codes. I think it's a simple implementation and can't identify Gregorian mode.
So I think if someone is willing to contribute a more advanced algorithm, it will be more useful.
If a melody has more than one key, what behavior is appropriate?
Complicate... Maybe a perfect solution will be found in the latest paper.
If someone can implement an algorithm better than music21, it would be exciting.
@johncwok
PR #28 introduced the
scale_identification
functionality. Currently is not yet exported because the following things must be improved / modified:seranade_full.mid
is a recording of serenade to a cuckoo. It should be tested as well. In addition the filetestmidi()
is Doxy, which should also be tested.sort(Dict(
is deprecated, we have to re-work the code a bit to do sorting after the dict is collected (sort keys and use sort indices on values as well) .The text was updated successfully, but these errors were encountered: