Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the MIDI.jl and ditch libmidi ? #9

Closed
Datseris opened this issue Sep 15, 2018 · 2 comments
Closed

Switch to the MIDI.jl and ditch libmidi ? #9

Datseris opened this issue Sep 15, 2018 · 2 comments
Labels
decision A decision has to be taken on whether to proceed with this or not speculative Nothing is certain about what is stated here

Comments

@Datseris
Copy link
Member

MIDI.jl is a well tested (on all OS), well documented and easy to use package for reading midi files. It also offers robust support for Notes, in the Julian way.

Most importantly, it is written purely in Julia and has 0 dependencies and 0 external libraries.

What would it take for Mplay to use MIDI.jl instead of libmidi? I am guessing some kind of 'streaming loading' interface? If @jheinen could have a look at MIDI.jl and tell me what would be necessary, I'd be happy to do some work to switch there.
@Datseris Datseris added decision A decision has to be taken on whether to proceed with this or not speculative Nothing is certain about what is stated here labels Sep 15, 2018
@jheinen
Copy link
Collaborator

jheinen commented Sep 15, 2018 •
edited
Loading

libmidi is not used to read MIDI files. It's used for MIDI device I/O. Could also be implemented in pure Julia, but does not make sense IMO.

@Datseris
Copy link
Member Author

Yeah then it makes sense. In MIDI.jl there has always been some desire for some stream based interface: JuliaMusic/MIDI.jl#32

but it hasn't happened and I am not sure it ever will. We can revive this if this ever happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision A decision has to be taken on whether to proceed with this or not speculative Nothing is certain about what is stated here
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jheinen @Datseris