Add SequencerSpecificEvent , and empty!(::MIDITrack)
#173
Conversation
|
Thank you for your review. If you decide merge, please make a new release, thank you very much. |
|
Thank you for your review! I have finished all the suggested changes. |
| @@ -31,4 +31,11 @@ | |||
| @test_throws errtype MIDI.readsysexevent(Int(input[1]), IOBuffer(input[2:length(input)])) | |||
| end | |||
| end | |||
|
|
|||
| @testset "SequencerSpecificEvent" begin | |||
| midi = load("SequencerSpecific.mid") | |||
There was a problem hiding this comment.
i don't undertstand what you are doing here. You are loading this midi data, but you don't use them next in the test suite...? The current test suite is meaningless you are only testing whether you initialized the SequencerSpecificEvent with the values you initialized it with. Rather trivial, no?
There was a problem hiding this comment.
Yes, I don't think it's necessary to actually use this midi data.
If the added code is incorrect, an error will be throwed on this line when initialization, and causing the test to fail.
The fact that no exception is thrown already indicates that SequencerSpecificEvent is being parsed and instantiated correctly.
There was a problem hiding this comment.
Tests have been added
There was a problem hiding this comment.
What, no not at all. What we want to know is whether we correctly find this special midi type in an actual midi track that we load. Instantiating the type is trivial, you aren't testing anything really if you only test that.
There was a problem hiding this comment.
But now we have this midi file, and it is very small, so thank you, this is exactly what I was asking for!
|
Also implement |
NeroBlackstone
changed the title
empty!(::MIDITrack)
| @@ -31,4 +31,11 @@ | |||
| @test_throws errtype MIDI.readsysexevent(Int(input[1]), IOBuffer(input[2:length(input)])) | |||
| end | |||
| end | |||
|
|
|||
| @testset "SequencerSpecificEvent" begin | |||
| midi = load("SequencerSpecific.mid") | |||
There was a problem hiding this comment.
But now we have this midi file, and it is very small, so thank you, this is exactly what I was asking for!
|
@Datseris Hi, would you mind make a new release? Thank you very much 😊👍 |
Related issue #172