Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Notes by chord notation. #161

Closed
NeroBlackstone opened this issue Jan 28, 2023 · 4 comments
Closed

Initialize Notes by chord notation. #161

NeroBlackstone opened this issue Jan 28, 2023 · 4 comments

Comments

@NeroBlackstone
Copy link
Member

NeroBlackstone commented Jan 28, 2023

Motivation: Quick initialize notes by chord notation strings.

Notes(chord_notation::String, tpq::Int = 960) 
Notes("C")
# construct a notes have C–E–G note
@Datseris
Copy link
Member

Not possible, because "C" also means the note "C". You can make a new function notes_from_chord(::String) that accepts a chord notation and gives all notes. Although, it still becomes a bit ambiguous what "fingering" or note ordering you should use for the chord.

@NeroBlackstone
Copy link
Member Author

Not possible, because "C" also means the note "C". You can make a new function notes_from_chord(::String) that accepts a chord notation and gives all notes.

Agree.

Although, it still becomes a bit ambiguous what "fingering" or note ordering you should use for the chord.

Pitch low to pitch high, I think.

@NeroBlackstone
Copy link
Member Author

I think we need to implement Interval calculation on Note before implementing notes_from_chord. Because notes of the chord conform to a fixed interval relationship. So once we implement Interval calculation, we can get the rest of notes from the root note of chord.

I have some ideas about how to represent Intervals, I'll post my thoughts in a few days.

@NeroBlackstone
Copy link
Member Author

Close this issue, all the manipulation about Music Theory should implement in MusicTheory.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants