From dc102e270b7bd499ae82b99fdee42fe6a75b7029 Mon Sep 17 00:00:00 2001 From: Lilith Orion Hafner Date: Sat, 14 Oct 2023 11:01:27 -0500 Subject: [PATCH 01/42] Try using typos in CI --- .github/workflows/SpellCheck.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflows/SpellCheck.yml diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml new file mode 100644 index 0000000000000..e5610862bf1e5 --- /dev/null +++ b/.github/workflows/SpellCheck.yml @@ -0,0 +1,15 @@ +name: Spell Check + +permissions: {} + +on: [pull_request] + +jobs: + typos-check: + name: Spell Check with Typos + runs-on: ubuntu-latest + steps: + - name: Checkout Actions Repository + uses: actions/checkout@v4 + - name: Check spelling + uses: crate-ci/typos@master From fe586bba2fdad1edd658a153e8716d58ac371ac1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:38:04 -0400 Subject: [PATCH 02/42] Apply suggestions from code review --- .github/workflows/SpellCheck.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index e5610862bf1e5..70d14f0c4dbe1 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -11,5 +11,7 @@ jobs: steps: - name: Checkout Actions Repository uses: actions/checkout@v4 + with: + persist-credentials: false - name: Check spelling uses: crate-ci/typos@master From 83926ab01f56b1b7f3e1ecbfe0986ecc41140ee0 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:38:51 -0400 Subject: [PATCH 03/42] Apply suggestions from code review --- .github/workflows/SpellCheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 70d14f0c4dbe1..c75ca9edf14b2 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -1,6 +1,7 @@ name: Spell Check -permissions: {} +permissions: + contents: read on: [pull_request] From 18e15229895f2c9c6333fee9317090cbe90ab96d Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:40:40 -0400 Subject: [PATCH 04/42] Apply suggestions from code review --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index c75ca9edf14b2..0dec4f54ff279 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -10,7 +10,7 @@ jobs: name: Spell Check with Typos runs-on: ubuntu-latest steps: - - name: Checkout Actions Repository + - name: Checkout the JuliaLang/julia repository uses: actions/checkout@v4 with: persist-credentials: false From 2c7b9b46224d3be759e13eaa8cde5e849aba143d Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:13:35 -0400 Subject: [PATCH 05/42] Set a 5-minute timeout (Apply suggestions from code review) --- .github/workflows/SpellCheck.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 0dec4f54ff279..341d5f52f8734 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -9,6 +9,7 @@ jobs: typos-check: name: Spell Check with Typos runs-on: ubuntu-latest + timeout-minutes: 5 steps: - name: Checkout the JuliaLang/julia repository uses: actions/checkout@v4 From 4e25d37afd0bda8ef49fccbccffdd42c687cc354 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:25:04 -0400 Subject: [PATCH 06/42] Switch back to `permissions: {}` (Apply suggestions from code review) --- .github/workflows/SpellCheck.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 341d5f52f8734..3325a113015c9 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -1,7 +1,6 @@ name: Spell Check -permissions: - contents: read +permissions: {} on: [pull_request] From fc275a4f4967ed4781e8c9bb709f7b7b3e907049 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:32:15 -0400 Subject: [PATCH 07/42] CI: Also try `codespell` --- .github/workflows/SpellCheck.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 3325a113015c9..8c6f0ae5d587f 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -16,3 +16,12 @@ jobs: persist-credentials: false - name: Check spelling uses: crate-ci/typos@master + codespell: + https://github.com/codespell-project/codespell + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + persist-credentials: false + - run: pip install codespell + - run: codespell From 3f3bb0493dbfb107468ee4deff4e879911b70b3b Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:33:21 -0400 Subject: [PATCH 08/42] Fix a syntax error --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 8c6f0ae5d587f..fad1d899c18ef 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -17,7 +17,7 @@ jobs: - name: Check spelling uses: crate-ci/typos@master codespell: - https://github.com/codespell-project/codespell + # https://github.com/codespell-project/codespell runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From 6402c5313f6ef1f249da6b7cf10efa01ee640bc5 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 12:55:21 -0400 Subject: [PATCH 09/42] Add a short timeout --- .github/workflows/SpellCheck.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index fad1d899c18ef..ad488c6d065a0 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -19,6 +19,7 @@ jobs: codespell: # https://github.com/codespell-project/codespell runs-on: ubuntu-latest + timeout-minutes: 5 steps: - uses: actions/checkout@v4 with: From e7081ff136250e6bf181a348c396e302d00c3243 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:30:02 -0400 Subject: [PATCH 10/42] Add a `codespell` ignore file --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.ignore diff --git a/.codespell.ignore b/.codespell.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.ignore @@ -0,0 +1 @@ + From 39cb8f522ad7eba0aa69589558db425383951461 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:30:33 -0400 Subject: [PATCH 11/42] Use the `codespell` ignore file --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index ad488c6d065a0..fefa252166d73 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -25,4 +25,4 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell + - run: codespell --ignore-words=.codespell.ignore From fbaf294f6a04c5e72164021205be5ccf71f19044 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:30:57 -0400 Subject: [PATCH 12/42] `codespell`: ignore `ans` --- .codespell.ignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codespell.ignore b/.codespell.ignore index 8b137891791fe..025839bf3d96b 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1 +1 @@ - +ans From babaf9874ffa9054e89c6d0492e41f06083485d9 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:31:19 -0400 Subject: [PATCH 13/42] `codespell`: ignore `egal` --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index 025839bf3d96b..74be7f4ccda0c 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1 +1,2 @@ ans +egal From ed372553ae96d78562e28d6b18e7d0bca31e4024 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:36:58 -0400 Subject: [PATCH 14/42] `codespell`: ignore `findn` Note: In https://github.com/JuliaLang/julia/issues/25532, `findn(x::AbstractArray)` was deprecated in favor of `findall(!iszero, x)`. However, the word `findn` will still appear in various places, such as `HISTORY.md`, so we should probably ignore it from `codespell`. --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index 74be7f4ccda0c..91fb8b64f5919 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,2 +1,3 @@ ans egal +findn From df42a232ed417edf69163a23bd167b84b6031c0e Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:38:04 -0400 Subject: [PATCH 15/42] `codespell`: ignore `whos` Note: In https://github.com/JuliaLang/julia/issues/12131, `whos` was renamed to `varinfo`. However, the name `whos` still appears in the `HISTORY.md` file, and thus we probably need to ignore it from `codespell`. --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index 91fb8b64f5919..cad473285b1ec 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,3 +1,4 @@ ans egal findn +whos From c9499d2249a7fa21d20749f2c150572d65fceb3f Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:39:16 -0400 Subject: [PATCH 16/42] `codespell`: ignore `caf` `caf` is used in an example in `HISTORY.md`. --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index cad473285b1ec..f87875f124083 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,4 +1,5 @@ ans +caf egal findn whos From 9c7fde76540d38393daf741b00a7ef4b0c77562f Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:40:42 -0400 Subject: [PATCH 17/42] `codespell`: ignore `dout` `dout` is used as a variable name in `./stdlib/FileWatching/test/runtests.jl`. --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index f87875f124083..761530f28fb40 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,5 +1,6 @@ ans caf +dout egal findn whos From 57b08d13cef9a157ede41c1e3b5429c64d3123d8 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:41:31 -0400 Subject: [PATCH 18/42] `codespell`: ignore `afile` `afile.txt` is used as a filename in `./stdlib/FileWatching/test/runtests.jl`. --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index 761530f28fb40..b730cecf28ae9 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,3 +1,4 @@ +afile ans caf dout From 646f53b2e069382b215c9e00d3f01c835e727910 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:42:43 -0400 Subject: [PATCH 19/42] `codespell`: ignore `te` `te` is used in some strings in `./stdlib/Printf/test/runtests.jl` --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index b730cecf28ae9..ba9bfb26488b0 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -4,4 +4,5 @@ caf dout egal findn +te whos From 63fcbbe13934f33ba0508e9dac73896fb8f43360 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:43:01 -0400 Subject: [PATCH 20/42] `codespell`: ignore `fo` `fo` is used in some strings in `./stdlib/Printf/test/runtests.jl` --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.codespell.ignore b/.codespell.ignore index ba9bfb26488b0..5f115c0876f1c 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -4,5 +4,6 @@ caf dout egal findn +fo te whos From 32037628cec431f76526715d396050be058e3485 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:51:35 -0400 Subject: [PATCH 21/42] Add a separate `codespell` job for assembly files --- .github/workflows/SpellCheck.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index fefa252166d73..880ee8d15f207 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -25,4 +25,15 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --ignore-words=.codespell.ignore + # All files except assembly files (*.S) + - run: codespell --skip='*.S' --ignore-words=.codespell.ignore + codespell-asm: + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - uses: actions/checkout@v4 + with: + persist-credentials: false + - run: pip install codespell + # Only assembly files + - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm' From 66ff6f246ba8b78f050473a33a823c4c75a0590c Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:51:56 -0400 Subject: [PATCH 22/42] Add a separate `codespell` ignore file for assembly --- .codespell.asm.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.asm.ignore diff --git a/.codespell.asm.ignore b/.codespell.asm.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.asm.ignore @@ -0,0 +1 @@ + From 0ec1ca38db076b5330a2fb53bb6ca7082eaf1ffd Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:52:32 -0400 Subject: [PATCH 23/42] Use the separate `codespell` ignore file for assembly --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 880ee8d15f207..1a4662eff8cca 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -36,4 +36,4 @@ jobs: persist-credentials: false - run: pip install codespell # Only assembly files - - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm' + - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm' --ignore-words=.codespell.asm.ignore From 29297a6d4fea6d1d8c3f9a91d258194d2d465cd8 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:54:35 -0400 Subject: [PATCH 24/42] `codespell`: ignore `seh` and `SEH` in assembly files On Windows, SEH = Structured Exception Handling. --- .codespell.asm.ignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.codespell.asm.ignore b/.codespell.asm.ignore index 8b137891791fe..4e6c5203fdd96 100644 --- a/.codespell.asm.ignore +++ b/.codespell.asm.ignore @@ -1 +1,2 @@ - +seh +SEH From c252a5b32e24ab342d5db5fec8b4eac80bc2d436 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:56:30 -0400 Subject: [PATCH 25/42] Add some more file extensions: `*.h`, `*.iss`, `*.rtf`, and `*.toml` --- .github/workflows/SpellCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 1a4662eff8cca..e96f044ecc914 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -36,4 +36,4 @@ jobs: persist-credentials: false - run: pip install codespell # Only assembly files - - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm' --ignore-words=.codespell.asm.ignore + - run: codespell --skip='*.c,*.cpp,*.h,*.iss,*.jl,*.md,*.rtf,*.scm,*.toml' --ignore-words=.codespell.asm.ignore From 78d259b76e586e26e0add801d1d0996a62c69012 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 13:57:45 -0400 Subject: [PATCH 26/42] Different file extensions should have different `codespell` ignore files --- .codespell.ignore | 3 --- 1 file changed, 3 deletions(-) diff --git a/.codespell.ignore b/.codespell.ignore index 5f115c0876f1c..f87c8fbfc031a 100644 --- a/.codespell.ignore +++ b/.codespell.ignore @@ -1,9 +1,6 @@ afile -ans -caf dout egal -findn fo te whos From 1c961ddd287453626ed976d9a713a34a1a615418 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:00:31 -0400 Subject: [PATCH 27/42] Different file extensions should have different `codespell` ignore files --- .codespell.md.ignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .codespell.md.ignore diff --git a/.codespell.md.ignore b/.codespell.md.ignore new file mode 100644 index 0000000000000..275407c668fe9 --- /dev/null +++ b/.codespell.md.ignore @@ -0,0 +1,3 @@ +ans +caf +findn From 9fa7ba06d023c802fa1636bf7320c4a51a929b75 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:00:43 -0400 Subject: [PATCH 28/42] Different file extensions should have different `codespell` ignore files --- .codespell.ignore => .codespell.jl.ignore | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .codespell.ignore => .codespell.jl.ignore (100%) diff --git a/.codespell.ignore b/.codespell.jl.ignore similarity index 100% rename from .codespell.ignore rename to .codespell.jl.ignore From 2c5037dc3d3127dc20c7b74f70fcbeec8ef1bc7f Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:01:24 -0400 Subject: [PATCH 29/42] Different file extensions should have different `codespell` ignore files --- .codespell.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.ignore diff --git a/.codespell.ignore b/.codespell.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.ignore @@ -0,0 +1 @@ + From ce3f9c5f36e07dfce66e09cca2ba5a362d54a4d2 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:01:39 -0400 Subject: [PATCH 30/42] Different file extensions should have different `codespell` ignore files --- .github/workflows/SpellCheck.yml | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index e96f044ecc914..ee26b212d2f82 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -18,6 +18,7 @@ jobs: uses: crate-ci/typos@master codespell: # https://github.com/codespell-project/codespell + # This is a catch-all job to cover file extensions that aren't in another job runs-on: ubuntu-latest timeout-minutes: 5 steps: @@ -25,8 +26,27 @@ jobs: with: persist-credentials: false - run: pip install codespell - # All files except assembly files (*.S) - - run: codespell --skip='*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.jl,*.md,*.S' --ignore-words=.codespell.ignore + codespell-jl: + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - uses: actions/checkout@v4 + with: + persist-credentials: false + - run: pip install codespell + # Only Julia files (*.jl) + - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.jl.ignore {} \; + codespell-md: + runs-on: ubuntu-latest + timeout-minutes: 5 + steps: + - uses: actions/checkout@v4 + with: + persist-credentials: false + - run: pip install codespell + # Only Markdown files (*.md) + - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.md.ignore {} \; codespell-asm: runs-on: ubuntu-latest timeout-minutes: 5 @@ -35,5 +55,5 @@ jobs: with: persist-credentials: false - run: pip install codespell - # Only assembly files - - run: codespell --skip='*.c,*.cpp,*.h,*.iss,*.jl,*.md,*.rtf,*.scm,*.toml' --ignore-words=.codespell.asm.ignore + # Only assembly files (*.S) + - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.asm.ignore {} \; From 6e40eb1a188ff44ff684242c17f80fe419644aca Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:05:09 -0400 Subject: [PATCH 31/42] Use a GitHub Actions job matrix --- .github/workflows/SpellCheck.yml | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index ee26b212d2f82..e8c922568dec9 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -27,33 +27,19 @@ jobs: persist-credentials: false - run: pip install codespell - run: codespell --skip='*.jl,*.md,*.S' --ignore-words=.codespell.ignore - codespell-jl: + codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 + strategy: + fail-fast: false + matrix: + file-extension: + - 'jl' + - 'md' + - 'S' steps: - uses: actions/checkout@v4 with: persist-credentials: false - run: pip install codespell - # Only Julia files (*.jl) - - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.jl.ignore {} \; - codespell-md: - runs-on: ubuntu-latest - timeout-minutes: 5 - steps: - - uses: actions/checkout@v4 - with: - persist-credentials: false - - run: pip install codespell - # Only Markdown files (*.md) - - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.md.ignore {} \; - codespell-asm: - runs-on: ubuntu-latest - timeout-minutes: 5 - steps: - - uses: actions/checkout@v4 - with: - persist-credentials: false - - run: pip install codespell - # Only assembly files (*.S) - - run: find . -type f -name '*.S' -exec codespell --ignore-words=.codespell.asm.ignore {} \; + - run: find . -type f -name '*.${{ matrix.file-extension }}' -exec codespell --ignore-words=.codespell.jl.ignore {} \; From 55470a33cf1a4fd2315889fda95c26fe24a1eaf2 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:06:56 -0400 Subject: [PATCH 32/42] Create .codespell.scm.ignore --- .codespell.scm.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.scm.ignore diff --git a/.codespell.scm.ignore b/.codespell.scm.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.scm.ignore @@ -0,0 +1 @@ + From afa7ce86d769937aabc23a4bd2b1e74bceda78ec Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:08:43 -0400 Subject: [PATCH 33/42] Give Scheme files their own job in the `codespell` matrix --- .github/workflows/SpellCheck.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index e8c922568dec9..a0222bc807a76 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -26,7 +26,7 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --skip='*.jl,*.md,*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 @@ -34,9 +34,10 @@ jobs: fail-fast: false matrix: file-extension: - - 'jl' - - 'md' - - 'S' + - 'jl' # Julia files + - 'md' # Markdown files + - 'scm' # Scheme (femtolisp) files + - 'S' # Assembly language files steps: - uses: actions/checkout@v4 with: From 4f72c4e315f335cd4af1deff2d54b4eae1fd4ec1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:13:17 -0400 Subject: [PATCH 34/42] Put C source files into their own `codespell` job --- .codespell.c.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.c.ignore diff --git a/.codespell.c.ignore b/.codespell.c.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.c.ignore @@ -0,0 +1 @@ + From 226e10ae54af5d6bcd5123531390a43595439c09 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:13:46 -0400 Subject: [PATCH 35/42] Put C source files into their own `codespell` job --- .github/workflows/SpellCheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index a0222bc807a76..095718fd135be 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -26,7 +26,7 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --skip='*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.c,*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 @@ -34,6 +34,7 @@ jobs: fail-fast: false matrix: file-extension: + - 'c' # C files - 'jl' # Julia files - 'md' # Markdown files - 'scm' # Scheme (femtolisp) files From cac995f2cfd91079e5dfa74fa18d421bb2331a71 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:14:41 -0400 Subject: [PATCH 36/42] Put `.cpp` files into their own `codespell` job --- .codespell.cpp.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.cpp.ignore diff --git a/.codespell.cpp.ignore b/.codespell.cpp.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.cpp.ignore @@ -0,0 +1 @@ + From 973648d914f5fb07a87b3d3ef490375cd601e4ee Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:15:17 -0400 Subject: [PATCH 37/42] Put `.cpp` files into their own `codespell` job --- .github/workflows/SpellCheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 095718fd135be..f41b38e3cb990 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -26,7 +26,7 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --skip='*.c,*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 @@ -35,6 +35,7 @@ jobs: matrix: file-extension: - 'c' # C files + - 'cpp' # C++ files - 'jl' # Julia files - 'md' # Markdown files - 'scm' # Scheme (femtolisp) files From 7d9c5aacfb9b7f7f7a087e4bc158f556b927381c Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:16:54 -0400 Subject: [PATCH 38/42] Need to rename a file (now that we use GitHub Actions job matrices) --- .codespell.asm.ignore => .codespell.S.ignore | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .codespell.asm.ignore => .codespell.S.ignore (100%) diff --git a/.codespell.asm.ignore b/.codespell.S.ignore similarity index 100% rename from .codespell.asm.ignore rename to .codespell.S.ignore From 35eb94184f8384f4a7bdaa144d80c6e88397ccdd Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:23:52 -0400 Subject: [PATCH 39/42] Put `.toml` files in their own `codespell` job --- .codespell.toml.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.toml.ignore diff --git a/.codespell.toml.ignore b/.codespell.toml.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.toml.ignore @@ -0,0 +1 @@ + From 59d2f5ba3f21728023d38d0afb949d8fdaeb4a2b Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:24:13 -0400 Subject: [PATCH 40/42] Put `.toml` files in their own `codespell` job --- .github/workflows/SpellCheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index f41b38e3cb990..5f0802fed5a66 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -26,7 +26,7 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm,*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm,*.toml,*.S' --ignore-words=.codespell.ignore codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 @@ -39,6 +39,7 @@ jobs: - 'jl' # Julia files - 'md' # Markdown files - 'scm' # Scheme (femtolisp) files + - 'toml' # TOML files - 'S' # Assembly language files steps: - uses: actions/checkout@v4 From 4ec4392cc3748005729fc5c5bba6b2f22ce51b48 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:25:58 -0400 Subject: [PATCH 41/42] Put `.rtf` files in their own `codespell` job --- .codespell.rtf.ignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .codespell.rtf.ignore diff --git a/.codespell.rtf.ignore b/.codespell.rtf.ignore new file mode 100644 index 0000000000000..8b137891791fe --- /dev/null +++ b/.codespell.rtf.ignore @@ -0,0 +1 @@ + From 8cd06a706dea93031f73f8f3ba2f0a746aae1c4a Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Oct 2023 14:26:32 -0400 Subject: [PATCH 42/42] Put `.rtf` files in their own `codespell` job --- .github/workflows/SpellCheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index 5f0802fed5a66..c6c9eae6e4be8 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -26,7 +26,7 @@ jobs: with: persist-credentials: false - run: pip install codespell - - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.scm,*.toml,*.S' --ignore-words=.codespell.ignore + - run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.rtf,*.scm,*.toml,*.S' --ignore-words=.codespell.ignore codespell-file-extension: runs-on: ubuntu-latest timeout-minutes: 5 @@ -38,6 +38,7 @@ jobs: - 'cpp' # C++ files - 'jl' # Julia files - 'md' # Markdown files + - 'rtf' # RTF (Rich Text Format) files - 'scm' # Scheme (femtolisp) files - 'toml' # TOML files - 'S' # Assembly language files