Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port] Use ismutable in johnson_shortest_paths #68

Closed
gdalle opened this issue Nov 11, 2021 · 2 comments
Closed

[Port] Use ismutable in johnson_shortest_paths #68

gdalle opened this issue Nov 11, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@gdalle
Copy link
Member

gdalle commented Nov 11, 2021

See sbromberger/LightGraphs.jl#1597
@gdalle gdalle added the enhancement New feature or request label Nov 11, 2021
@simonschoelly
Copy link
Member

Note that ismutable is only available from Julia v1.5 on. Therefore one should either use ismutable from Compat.jl or create a method that checks for the Julia version and acts accordingly.

And while someone is on that, maybe they can also replace this line

Graphs.jl/src/shortestpaths/johnson.jl

Line 38 in 761912f

if type_distmx != Graphs.DefaultDistance
with one that uses isa.

@simonschoelly simonschoelly added bug Something isn't working good first issue Good for newcomers labels Nov 22, 2021
@simonschoelly
Copy link
Member

Solved by 574897a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonschoelly @gdalle