-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] [BUG] adjacency_matrix
fails for SimpleGraph
with self-loops (Julia 1.7)
#67
Comments
Fixed by #15 |
@etienneINSA what is the rationale of allowing loops in a SimpleGraph? I'm all for a more explicit error message, but shouldn't this be forbidden from the start? |
In my understanding, SimpleGraphs (in the context of this library) allows self-loops (but no multiple edges), but I may be wrong... @jpfairbanks ? |
Self-loops where at one point allowed on purpose. And I would agree, while the strict mathematical definition of a simple graph does not allow self-loops, it is a nice feature to have. One downside of that is though, that it adds additional edge cases that have to be checked for some algorithms. |
Fixed by #15 |
See sbromberger/LightGraphs.jl#1594
The text was updated successfully, but these errors were encountered: