-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in A* implementation #120
Comments
if a vertex is expanded several times, are the following ones redundant with the first time this vertex is encountered? From your message I assume not |
Probably not, because this means we have found a cheaper path to said vertex, which may reveal a cheaper path to its neighbors |
I'm ok with removing this. Even better if there is an example that fails to add to the tests |
Hello! Just looking into this as well Looks like the Wikipedia page you referenced used to have the closed_set documented in its algorithm, found a reference to an older version of the page Pretty much all the implementations I've found online use a closed_set, e.g. another julia package, python, c++, even this youtube video According to this source and this, both may be correct:
|
I left the |
In the implementation of the A* algorithm, there is a vector called
closed_set
which is used to indicate whether a vertex has already been expanded.Judging by the similar notations, this implementation is taken almost as-is from the Wikipedia page, but on Wikipedia the
closed_set
does not exist. In fact, the article clearly states thatTherefore, I think the presence of
closed_set
in the code is a mistake and should be corrected.The text was updated successfully, but these errors were encountered: