Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPSConv #351

Open
abieler opened this issue Oct 31, 2023 · 1 comment · May be fixed by #355
Open

GPSConv #351

abieler opened this issue Oct 31, 2023 · 1 comment · May be fixed by #355

Comments

@abieler
Copy link
Contributor

abieler commented Oct 31, 2023 •
edited
Loading

Would be fun to have the GPSConv layer in here and I'd be happy to take a crack at it (if deemed useful).

Should be straight forward, except the "global attention" part. Not sure if there is already an implementation somewhere to just add as a dependency (NeuralAttentionlib?) or if implementing it here directly would be the way to go. any thoughts?

https://arxiv.org/abs/2205.12454

https://pytorch-geometric.readthedocs.io/en/latest/generated/torch_geometric.nn.conv.GPSConv.html#:~:text=The%20GPS%20layer%20is%20based,operates%20on%20the%20input%20graph.
@CarloLucibello
Copy link
Member

Maybe the attention can be implemented through the NNlib's attention function https://github.com/FluxML/NNlib.jl/blob/master/src/attention.jl

@CarloLucibello CarloLucibello linked a pull request Jan 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First draft GPS conv layer abieler/GraphNeuralNetworks.jl
2 participants
@CarloLucibello @abieler