From 81534884663d7d5d0a171dfd1dd6e4239e23f788 Mon Sep 17 00:00:00 2001
From: Carlo Lucibello <carlo.lucibello@gmail.com>
Date: Sat, 21 Dec 2024 01:15:23 +0100
Subject: [PATCH] fix show for non-array (#564)

---
 .gitignore                 | 1 +
 GNNGraphs/src/gnngraph.jl  | 8 ++++++--
 GNNGraphs/test/gnngraph.jl | 7 +++++++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index d7d1ab579..3b60b63b8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,3 +19,4 @@ GraphNeuralNetworks/docs/src/GNNGraphs
 GraphNeuralNetworks/docs/src/GNNlib
 tutorials/docs/build
 prova.jl
+pyg.ipynb
diff --git a/GNNGraphs/src/gnngraph.jl b/GNNGraphs/src/gnngraph.jl
index 9934229f7..d7391f3c8 100644
--- a/GNNGraphs/src/gnngraph.jl
+++ b/GNNGraphs/src/gnngraph.jl
@@ -230,16 +230,20 @@ function Base.copy(g::GNNGraph; deep = false)
     end
 end
 
+feature_summary(x::AbstractArray) = "$(dims2string(size(x)))"
+feature_summary(x::AbstractString) = "string($(length(x)))"
+feature_summary(x::T) where T = "$T"
+
 function print_feature(io::IO, feature)
     if !isempty(feature)
         if length(keys(feature)) == 1
             k = first(keys(feature))
             v = first(values(feature))
-            print(io, "$(k): $(dims2string(size(v)))")
+            print(io, "$(k): $(feature_summary(v))")
         else
             print(io, "(")
             for (i, (k, v)) in enumerate(pairs(feature))
-                print(io, "$k: $(dims2string(size(v)))")
+                print(io, "$k: $(feature_summary(v))")
                 if i == length(feature)
                     print(io, ")")
                 else
diff --git a/GNNGraphs/test/gnngraph.jl b/GNNGraphs/test/gnngraph.jl
index 0c15e6cff..abe9518cb 100644
--- a/GNNGraphs/test/gnngraph.jl
+++ b/GNNGraphs/test/gnngraph.jl
@@ -344,6 +344,13 @@ end
     @test g1 !== g2
 end
 
+@testset "show" begin
+    # no throw when global data is not an array
+    g = rand_graph(10, 20, gdata = "ciao")
+    @test sprint(show, g) == "GNNGraph(10, 20) with u: string(4) data"
+    @test sprint(show, MIME("text/plain"), g) == "GNNGraph:\n  num_nodes: 10\n  num_edges: 20\n  gdata:\n    u = 4-codeunit String"
+end
+
 ## Cannot test this because DataStore is not an ordered collection
 ## Uncomment when/if it will be based on OrderedDict
 # @testset "show" begin