-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PerspectiveCamera rotation (upvector) #76
Comments
Any reason not to do the change? I agree that if up-vector flips, then left-right rotations do not feel natural. |
Yes I think so, I should have added a comment there since I don't completely remember myself... But I think the rotations was getting super funky without a fixed upvector. |
If it's of any worth, I changed it locally on my pc since my post and haven't noticed any particular funkyness. Maybe I'm missing something though. |
GLAbstraction.jl/src/GLCamera.jl
Line 496 in 7f20d62
Hi,
I think
Vec3f(0,0,1)
in this line should be changed toup_v
. Previously the camera remained with the same upvector, causing left/right rotations to feel very weird after a while.(also this was what I mentioned in my last comment in JuliaGL/GLVisualize.jl#190 , I edited that comment)
grtz
The text was updated successfully, but these errors were encountered: