Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in estimate_delay when using exp_decay #64

Open
pucicu opened this issue Nov 24, 2020 · 1 comment
Open

Error in estimate_delay when using exp_decay #64

pucicu opened this issue Nov 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pucicu
Copy link

pucicu commented Nov 24, 2020

The function lag = estimate_delay(tr, "exp_decay", 0:100) can throw an error of the type

ERROR: The correlation function has elements that are ≤ 0. We can't fit an exponential to it. Please choose another method.

It is clear what it means (and the error can be avoided when using a shorter delay interval), but in my opinion it would be better to catch the situation where auto-correlation values could be negative and to truncate the auto-correlation function to the interval of positive values.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Datseris Datseris added the enhancement New feature or request label Nov 24, 2020
@Datseris
Copy link
Member

Ah okay, that's a fair and straightforward improvement.

@Datseris Datseris added the good first issue Good for newcomers label Nov 24, 2020
This was referenced Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants