Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose reset!(mapper) to the user #111

Open
Datseris opened this issue Oct 16, 2023 · 0 comments
Open

Expose reset!(mapper) to the user #111

Datseris opened this issue Oct 16, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers quality of life changes that improve user experience but don't bring new features

Comments

@Datseris
Copy link
Member

Necessary steps for this:

  • Make basins_of_attraction or basins_fractions return copies of the stored attractors
  • Ensure reset! resets the ID of latest attractor to 1. It doesn't matter for continuation what ID we set to as we do matching anyways at the end.
  • Add docstring to reset! and export the function and add it to the docs.
  • Define behavior of the function for the featurizing mapper. For proximity mapper it should do nothing.
@Datseris Datseris added documentation Improvements or additions to documentation good first issue Good for newcomers quality of life changes that improve user experience but don't bring new features labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers quality of life changes that improve user experience but don't bring new features
Projects
None yet
Development

No branches or pull requests

1 participant