Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number in Citation plugin is hard-coded #389

Open
oxinabox opened this issue Feb 23, 2023 · 2 comments
Open

Version number in Citation plugin is hard-coded #389

oxinabox opened this issue Feb 23, 2023 · 2 comments
Labels
good-first-issue A good issue for newcomers to the repo help wanted new-feature A proposed feature (which is not a new plugin)

Comments

@oxinabox
Copy link
Collaborator

The CITATION.bib file is hard-coded set version as v0.1.0
(#388 makes that hard coded to 1.0.0-dev instead)

PkgTemplates.jl/templates/CITATION.bib

Line 5 in aba4640

version = {v0.1.0},

We should instead use the version specified in the ProjectFile plugin (if present).

I think this would be a great first issue for someone.
Basically we would need to check the priority of Citation was after ProjectFile
then during the hook stage use getplugin to see if there is a ProjectFile plugin loaded and if so load the version from that.
which we would insert by putting a VERSION into the view and then updating the template to pull that.
If there is no ProjectFile plugin present, maybe we should just omit the version line from the Citation.bib all together?
@nickrobinson251 nickrobinson251 added help wanted good-first-issue A good issue for newcomers to the repo new-feature A proposed feature (which is not a new plugin) labels Feb 23, 2023
@Dhananjay-12
Copy link

Hi @oxinabox , will this work ?

citationbib

@oxinabox
Copy link
Collaborator Author

I don't think so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue A good issue for newcomers to the repo help wanted new-feature A proposed feature (which is not a new plugin)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oxinabox @nickrobinson251 @Dhananjay-12