add support for windows

Author: dashuai

.github/workflows/windows.yml

@@ -2,9 +2,9 @@ name: windows
 
 on:
   push:
-    branches: [ main ]
+    branches: [ master ]
   pull_request:
-    branches: [ main ]
+    branches: [ master ]
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

README.md

@@ -2,7 +2,8 @@
 
 -----------------
 
-[![CMake](https://github.com/qdslovelife/bustub/actions/workflows/codev.yml/badge.svg)](https://github.com/qdslovelife/bustub/actions/workflows/codev.yml)
+[![linux](https://github.com/qdslovelife/bustub/actions/workflows/codev.yml/badge.svg)](https://github.com/qdslovelife/bustub/actions/workflows/codev.yml)
+[![windows](https://github.com/qdslovelife/bustub/actions/workflows/windows.yml/badge.svg)](https://github.com/qdslovelife/bustub/actions/workflows/windows.yml)
 [![codecov](https://codecov.io/gh/qdslovelife/bustub/branch/master/graph/badge.svg?token=6Y2ZTDH9E1)](https://codecov.io/gh/qdslovelife/bustub)
 [![Language grade: C/C++](https://img.shields.io/lgtm/grade/cpp/g/qdslovelife/bustub.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/qdslovelife/bustub/context:cpp)
 
@@ -23,7 +24,7 @@ BusTub is a disk-oriented relational database management system built at [Carneg
 
 To ensure that you have the proper packages on your machine, run the following script to automatically install them.
 
-Note: This script will install GTest using [vcpkg](https://github.com/microsoft/vcpkg). If you don't like it, you can modify the script and  CMakeLists.txt and use it the way you prefer.
+Note: This script will install GTest using [vcpkg](https://github.com/microsoft/vcpkg).
 
 ```
 $ sudo build_support/packages.sh
@@ -38,6 +39,16 @@ $ cmake -DCMAKE_BUILD_TYPE=Debug -GNinja ..
 $ ninja
 ```
 
+### Windows
+
+```
+$ .\build_support\packages.bat
+```
+
+Use visual studio to open the folder, then you're done.
+
+Note: The version of visual studio I am using is [Visual Studio Community 2022 preview](https://visualstudio.microsoft.com/zh-hans/vs/)
+
 ## Format
 
 ```

src/catalog/table_generator.cpp

@@ -34,8 +34,7 @@ std::vector<Value> TableGenerator::GenNumericValues(ColumnInsertMeta *col_meta,
 
   std::default_random_engine generator;
   // TODO(Amadou): Break up in two branches if this is too weird.
-  std::conditional_t<std::is_integral_v<CppType>, std::uniform_int_distribution<>,
-                     std::uniform_real_distribution<>>
+  std::conditional_t<std::is_integral_v<CppType>, std::uniform_int_distribution<>, std::uniform_real_distribution<>>
       distribution(static_cast<CppType>(col_meta->min_), static_cast<CppType>(col_meta->max_));
   for (uint32_t i = 0; i < count; i++) {
     values.emplace_back(Value(col_meta->type_, distribution(generator)));

src/common/config.cpp

@@ -18,7 +18,7 @@ namespace bustub {
 __declspec(dllexport) std::atomic<bool> enable_logging(false);
 #else
 std::atomic<bool> enable_logging(false);
-#endif	// defined(_MSC_VER)
+#endif  // defined(_MSC_VER)
 
 #if defined(_MSC_VER)
 __declspec(dllexport) std::chrono::duration<int64_t> log_timeout(1);

src/include/buffer/buffer_pool_manager_instance.h

@@ -133,9 +133,9 @@ class BufferPoolManagerInstance : public BufferPoolManager {
   /** Array of buffer pool pages. */
   Page *pages_;
   /** Pointer to the disk manager. */
-  DiskManager *disk_manager_ [[maybe_unused]];
+  DiskManager *disk_manager_[[maybe_unused]];
   /** Pointer to the log manager. */
-  LogManager *log_manager_ [[maybe_unused]];
+  LogManager *log_manager_[[maybe_unused]];
   /** Page table for keeping track of buffer pool pages. */
   std::unordered_map<page_id_t, frame_id_t> page_table_;
   /** Replacer to find unpinned pages for replacement. */

src/include/common/config.h

@@ -26,7 +26,7 @@ extern std::chrono::milliseconds cycle_detection_interval;
 __declspec(dllimport) extern std::atomic<bool> enable_logging;
 #else
 extern std::atomic<bool> enable_logging;
-#endif	// defined(_MSC_VER)
+#endif  // defined(_MSC_VER)
 
 /** If ENABLE_LOGGING is true, the log should be flushed to disk every LOG_TIMEOUT. */
 #if defined(_MSC_VER)

src/include/concurrency/transaction_manager.h

@@ -102,8 +102,8 @@ class TransactionManager {
   }
 
   std::atomic<txn_id_t> next_txn_id_{0};
-  LockManager *lock_manager_ [[maybe_unused]];
-  LogManager *log_manager_ [[maybe_unused]];
+  LockManager *lock_manager_[[maybe_unused]];
+  LogManager *log_manager_[[maybe_unused]];
 
   /** The global transaction latch is used for checkpointing. */
   ReaderWriterLatch global_txn_latch_;

src/include/recovery/checkpoint_manager.h

@@ -35,9 +35,9 @@ class CheckpointManager {
   void EndCheckpoint();
 
  private:
-  TransactionManager *transaction_manager_ [[maybe_unused]];
-  LogManager *log_manager_ [[maybe_unused]];
-  BufferPoolManager *buffer_pool_manager_ [[maybe_unused]];
+  TransactionManager *transaction_manager_[[maybe_unused]];
+  LogManager *log_manager_[[maybe_unused]];
+  BufferPoolManager *buffer_pool_manager_[[maybe_unused]];
 };
 
 }  // namespace bustub

src/include/recovery/log_manager.h

@@ -64,11 +64,11 @@ class LogManager {
 
   std::mutex latch_;
 
-  std::thread *flush_thread_ [[maybe_unused]];
+  std::thread *flush_thread_[[maybe_unused]];
 
   std::condition_variable cv_;
 
-  DiskManager *disk_manager_ [[maybe_unused]];
+  DiskManager *disk_manager_[[maybe_unused]];
 };
 
 }  // namespace bustub

src/include/recovery/log_recovery.h

@@ -42,15 +42,15 @@ class LogRecovery {
   bool DeserializeLogRecord(const char *data, LogRecord *log_record);
 
  private:
-  DiskManager *disk_manager_ [[maybe_unused]];
-  BufferPoolManager *buffer_pool_manager_ [[maybe_unused]];
+  DiskManager *disk_manager_[[maybe_unused]];
+  BufferPoolManager *buffer_pool_manager_[[maybe_unused]];
 
   /** Maintain active transactions and its corresponding latest lsn. */
   std::unordered_map<txn_id_t, lsn_t> active_txn_;
   /** Mapping the log sequence number to log file offset for undos. */
   std::unordered_map<lsn_t, int> lsn_mapping_;
 
-  int offset_ [[maybe_unused]];
+  int offset_[[maybe_unused]];
   char *log_buffer_;
 };