Process urls when compiling SCSS
#321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interested on how this would work in this scenario: // index.scss
@import 'mixins';
@import 'partials/general/chat';
// _mixins.sxss
@mixin theme-icon ($icon) {
background-image: url('#{$icon)');
background-size: 24px;
background-position: center;
background-repeat: no-repeat;
}
// partials/general/_chat.scss
.da-toolbar::before {
@include theme-icon('../../assets/icon-delete.svg');
content: '';
display: block;
height: 30px;
width: 30px;
}Would it resolve the path from the mixin, or from the partial itself? |
|
As PostCSS runs before Sass it will see the mixin as a custom at rule and process // index.scss postcss
@import 'mixins';
@import 'partials/general/chat';
// _mixins.scss postcss
@mixin theme-icon ($icon) {
background-image: url('#{$icon}'); // `#{$icon}` doesn't exist so is returned as it is
background-size: 24px;
background-position: center;
background-repeat: no-repeat;
}
// partials/general/_chat.scss postcss
.da-toolbar::before {
@include theme-icon('../../assets/icon-delete.svg');
content: '';
display: block;
height: 30px;
width: 30px;
}/* index.scss sass */
.da-toolbar::before {
background-image: url('../../assets/icon-delete.svg');
background-size: 24px;
background-position: center;
background-repeat: no-repeat;
content: '';
display: block;
height: 30px;
width: 30px; } |
|
Ah, thanks for the info. |
|
Not sure if @Jiiks had something else in mind to accomplish this |
Maks-s
added a commit
to Maks-s/BetterDiscordApp
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320.