-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include different types of bathymetries #130
Comments
It could live in Originally posted by @JoshuaLampert in #135 (comment) |
When all |
We could think of making |
Closed by #147 |
In #127 we decided to define different types of bathymetries (flat, variable, mild slope) as structs, which are used to dispatch. In any case, we keep the bathymetry as variable in the equation to be able to possibly extend the package in the future to also deal with time-dependent bathymetries. This concept should also be used for the existing equations:
bathymetry_type
, flat bathymetry is still missing, see Svärd-Kalisch equations for flat bathymetry #148)The text was updated successfully, but these errors were encountered: