Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Bring in updated conventional-commits-parser types #174

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 17, 2024 · 1 comment · Fixed by #182
Closed
3 tasks done

🛠 Tooling: Bring in updated conventional-commits-parser types #174

JoshuaKGoldberg opened this issue Feb 17, 2024 · 1 comment · Fixed by #182
Labels
area: tooling Managing the repository's maintenance status: blocked Waiting for something else to be resolved

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Feb 17, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following #168 (comment), this repo now has an as assertion to work around incorrect @types/conventional-commits-parser types:

// options from https://github.com/conventional-changelog/conventional-changelog/issues/648#issuecomment-704867077
// https://github.com/JoshuaKGoldberg/should-semantic-release/issues/174
const { notes, type } = conventionalCommitsParser.sync(message, {
breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/,
} as object);

Filing this tracking issue to indicate that once the types are fixed, this repo can stop using an as.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added the area: tooling Managing the repository's maintenance label Feb 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved label Feb 17, 2024
@hyoban
Copy link
Contributor

hyoban commented Feb 20, 2024

Try to create a PR at DefinitelyTyped/DefinitelyTyped#68699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: blocked Waiting for something else to be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants