Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Return true for BREAKING CHANGE? #139

Closed
3 tasks done
steveluscher opened this issue Dec 2, 2023 · 3 comments · Fixed by #168
Closed
3 tasks done

🚀 Feature: Return true for BREAKING CHANGE? #139

steveluscher opened this issue Dec 2, 2023 · 3 comments · Fixed by #168
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@steveluscher
Copy link

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Conventional Commits dictates that BREAKING CHANGE is meaningful, in that it denotes a X.0.0 version bump.

Should we add this to the list of always meaningful commits?

Additional Info

No response

@steveluscher steveluscher added the type: feature New enhancement or request label Dec 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Dec 2, 2023
@JoshuaKGoldberg
Copy link
Owner

I'm 50/50 on whether this is a bug or feature, heh - agreed that if it's in the spec it should certainly be respected here. PRs very welcome. Thanks for filing!

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @steveluscher for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @steveluscher! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants