Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add more ignored commits #103

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 5, 2023 · 2 comments · Fixed by #112
Closed
3 tasks done

🚀 Feature: Add more ignored commits #103

JoshuaKGoldberg opened this issue Sep 5, 2023 · 2 comments · Fixed by #112
Assignees
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

These are the currently ignored types of commits:

const ignoredTypes = new Set(["chore", "docs"]);

That's not the full list of ignorable types though! build:, ci:, style:, refactor:, and test: are other common ones that shouldn't necessitate an automatic release. Let's add them in and update the unit tests.

Additional Info

I found those commit styles on https://www.conventionalcommits.org/en/v1.0.0 (search for "angular").

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! good first issue Good for newcomers, please hop on! type: feature New enhancement or request labels Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 2, 2023
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant