Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in a ensure-repository-directory rule equivalent #53

Closed
JoshuaKGoldberg opened this issue Sep 20, 2023 · 1 comment · Fixed by #123
Closed

Bring in a ensure-repository-directory rule equivalent #53

JoshuaKGoldberg opened this issue Sep 20, 2023 · 1 comment · Fixed by #123
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Full Recommended ...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 20, 2023 •
edited
Loading

https://github.com/kellyselden/eslint-plugin-json-files/blob/3a24e6f36b7828210a56070af4487cb5831f7f24/docs/rules/ensure-repository-directory.md ensures that if a package.json file's repository.directory is present, it matches the file's directory on disk. That makes sense and is a good idea. Let's add it in!

Blocked on #40, but once that PR is merged this will be good to go. ✅
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 20, 2023
Open
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Nov 6, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@JoshuaKGoldberg
feat: added valid-repository-directory rule (#123)
84035c3 
## PR Checklist

-   [x] Addresses an existing open issue: fixes #53
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Equivalent to `json-files/ensure-repository-directory`. Renamed to
`valid-*` to match the precedent of the existing rules
`valid-package-def` and `valid-package-dependency`.

Re-uses the `findJSONLiteralWithValue` utility and renames it to the
more appropriate `findPropertyWithKeyValue`
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.7.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Full Recommended Config
Development

Successfully merging a pull request may close this issue.

feat: added valid-repository-directory rule JoshuaKGoldberg/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg