Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in string value "format-*"/"*-format" rule for description #52

Open
JoshuaKGoldberg opened this issue Sep 20, 2023 · 1 comment
Open
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 20, 2023

https://npmpackagejsonlint.org/docs/rules#format-rules has three string formatting rules that provide value:

Edit: split out #130 and #131

It'd be good to have them in this plugin. But...

  • Should they be combined into one rule with options? Split into separate rules?
  • If they're separate rules, should the name template be format-* (to put together alphabetically) or *-format (to associate with the individual property)?
  • Note that these use the word "format" to refer to the contents of string property values - not a formatter like Prettier. Is there an equivalent other word that doesn't have the terminology overlap?

Blocked on #40, but once that PR is merged this will be good to go.

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Jan 20, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Now that I split out #130 and #131, all that's really left is description. Which makes this a much more specific rule! The same question before on "what do we call this?" applies.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Bring in string value "format-*"/"*-format" rule(s) Bring in string value "format-*"/"*-format" rule for description Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant