Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The recommended config doesn't enable the plugin for you #47

Open
Zamiell opened this issue Sep 20, 2023 · 2 comments
Open

The recommended config doesn't enable the plugin for you #47

Zamiell opened this issue Sep 20, 2023 · 2 comments
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Sep 20, 2023

Thus, this makes people consuming the plugin have to add extra boilerplate to their configs.

See e.g. unicorn's recommended config, which is considered best practice AFAIK.

@JoshuaKGoldberg
Copy link
Owner

I like it! Let's tackle this after #40.

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Sep 20, 2023
@JoshuaKGoldberg
Copy link
Owner

Reflecting on conversation from typescript-eslint/typescript-eslint#8149: I'm not convinced about this as much anymore. I've seen folks have setups that do the "magic" for them, then get confused when things don't work.

Also, the current linked unicorn config (https://github.com/sindresorhus/eslint-plugin-unicorn/blob/331b3068d3c03c6e28a073277f5aa81dc238db3b/configs/recommended.js) just enables rules. Is there a different link we should be looking at?

@JoshuaKGoldberg JoshuaKGoldberg added status: in discussion Not yet ready for implementation or a pull request and removed status: blocked Waiting for something else to be resolved labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants