Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Deduplicate posted comments #180

Open
3 tasks done
JoshuaKGoldberg opened this issue Jan 6, 2024 · 0 comments
Open
3 tasks done

🚀 Feature: Deduplicate posted comments #180

JoshuaKGoldberg opened this issue Jan 6, 2024 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 6, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, each contribution per user generates a single comment via the GitHub API:

// TODO: It'd be nice to deduplicate these comments.
// PRs that include multiple types will cause multiple comments...
// https://github.com/JoshuaKGoldberg/all-contributors-auto-action/issues/180
const newComment = await octokit.request(...commentRequestArgs);

I haven't investigated this deeply but think it should be able to ask for multiple contributions in a single comment. If a user has multiple contributions out of a single issue or PR, it'd be nice to mention multiple in a comment:

@allcontributors please add <person> for bug, maintenance

Additional Info

Within this repo, I'm guessing the postContributionComment function will need to be changed up a bit.

all-contributors/app#127 is a good starting reference to see things on the allcontributors side. Though that PR is for multiple contributors per comment. I'd really like to see multiple contribution types per comment.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant