Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Use relative paths instead of absolute in source maps #167

Open
3 tasks done
JoshuaKGoldberg opened this issue Jan 3, 2024 · 2 comments
Open
3 tasks done

🛠 Tooling: Use relative paths instead of absolute in source maps #167

JoshuaKGoldberg opened this issue Jan 3, 2024 · 2 comments
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 3, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Why is my local computer showing up here...

all-contributors-auto-action/dist/comments.d.ts.map

Line 1 in 4e5ce72

{"version":3,"file":"","sourceRoot":"","sources":["file:///Users/josh/repos/all-contributors-auto-action/src/comments.ts"],"names":[],"mappings":"AAAA,eAAO,MAAM,iBAAiB,QAIlB,CAAC;AAEb,eAAO,MAAM,aAAa,iCAAiC,CAAC"}

...surely there's a way to make source maps use relative paths, so there's no difference between building on different machines? 😱

Additional Info

Noted by @johnyreilly in https://github.com/johnnyreilly/schemar/blob/e25a63364a9d8b36c3da27558075c81d6d8152c7/dist/index.d.ts.map & co.
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 3, 2024
@JoshuaKGoldberg
Copy link
Owner Author

@allcontributors add @johnnyreilly for idea

@allcontributors allcontributors bot mentioned this issue Jan 3, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @johnnyreilly! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg