Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: Extended Name Section #40

Open
JonasKruckenberg opened this issue Jul 18, 2024 · 0 comments
Open

WASM: Extended Name Section #40

JonasKruckenberg opened this issue Jul 18, 2024 · 0 comments
Labels
wasm-proposal Related to a WebAssembly proposal

Comments

@JonasKruckenberg
Copy link
Owner

This is the tracking issue for the Extended Name Section proposal.

A preliminary implementation (temporarily disabled) can be found here

// fn parse_name_section(&mut self, reader: NameSectionReader<'wasm>) -> WasmResult<()> {
// for subsection in reader {
// match subsection? {
// Name::Module { name, .. } => {
// self.result.module.debug_info.names.module_name = Some(name);
// }
// Name::Function(names) => {
// for name in names {
// let name = name?;
//
// // Skip this naming if it's naming a function that
// // doesn't actually exist.
// if (name.index as usize) >= self.result.module.functions.len() {
// continue;
// }
//
// self.result
// .module
// .debug_info
// .names
// .func_names
// .insert(FuncIndex::from_u32(name.index), name.name);
// }
// }
// Name::Local(names) => {
// for naming in names {
// let name = naming?;
// let mut result = HashMap::default();
//
// for name in name.names {
// let name = name?;
//
// // Skip this naming if it's naming a function that
// // doesn't actually exist.
// if (name.index as usize) >= self.result.module.functions.len() {
// continue;
// }
//
// result.insert(name.index, name.name);
// }
//
// self.result
// .module
// .debug_info
// .names
// .locals_names
// .insert(FuncIndex::from_u32(name.index), result);
// }
// }
// Name::Global(names) => {
// for name in names {
// let name = name?;
// self.result
// .module
// .debug_info
// .names
// .global_names
// .insert(GlobalIndex::from_u32(name.index), name.name);
// }
// }
// Name::Data(names) => {
// for name in names {
// let name = name?;
// self.result
// .module
// .debug_info
// .names
// .data_names
// .insert(DataIndex::from_u32(name.index), name.name);
// }
// }
// Name::Label(_) => log::debug!("unused name subsection label"),
// Name::Type(_) => log::debug!("unused name subsection type"),
// Name::Table(_) => log::debug!("unused name subsection table"),
// Name::Memory(_) => log::debug!("unused name subsection memory"),
// Name::Element(_) => log::debug!("unused name subsection element"),
// Name::Field(_) => log::debug!("unused name subsection field"),
// Name::Tag(_) => log::debug!("unused name subsection tag"),
// Name::Unknown { .. } => {}
// }
// }
//
// Ok(())
// }

@JonasKruckenberg JonasKruckenberg added the wasm-proposal Related to a WebAssembly proposal label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasm-proposal Related to a WebAssembly proposal
Projects
None yet
Development

No branches or pull requests

1 participant