Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent failing TeamCity build due to a SonarQube error #44

Open
Thunderforge opened this issue Feb 28, 2018 · 6 comments

Comments

@Thunderforge
Copy link

While we have enjoyed using the TeamCity SonarQube plugin, we are concerned that a SonarQube error causes the TeamCity build to fail (thus causing any other builds in the build chain to not start). Since SonarQube running is not mission-critical, we want for SonarQube to silently fail and not block a build.

For example, we have a build chain that looks like this:

  • WebApp
    • Run Gradle
    • Run SonarQube Runner
  • Deploy WebApp
    • Run PowerShell Script

The build steps "Run Gradle" and "Run PowerShell Script" are mission-critical, but "Run SonarQube Runner" is not. Unfortunately, if it fails because our SonarQube server is offline, it fails the build and prevents Deploy WebApp from running. Having Deploy WebApp run even with failed dependencies is not possible, not only because that would allow Gradle failures, but also it doesn't work in our more complex build chains.

We would like for SonarQube Runner to have an option to silently fail if there is an error such as the SonarQube server being offline, thus not breaking our builds. The lack of this feature is a dealbreaker for using the Sonarqube Plugin for TeamCity.

@KellyR-STCU
Copy link

@Thunderforge Just a thought, but maybe this is actually a feature request for TeamCity?

@Thunderforge
Copy link
Author

@KellyR-STCU In what way would it be a feature request for TeamCity? Doesn't the SonarQube plugin tell TeamCity whether or not it failed?

@KellyR-STCU
Copy link

KellyR-STCU commented Jul 13, 2018

@Thunderforge I mean just as a general concept, "do not let this step fail the build regardless of if the step itself failed". It seems useful in a general sense and at least to me it seems a lot easier to do than to have to modify every single step that anyone makes for TeamCity to handle this differently.

@Linfar
Copy link
Member

Linfar commented Aug 17, 2018

I can try to add custom build failure condition enabled by default - something like "Fail the build if SonarQube Scanner fails". So that it will be possible to disable it.

@fapinheiro
Copy link

I can try to add custom build failure condition enabled by default - something like "Fail the build if SonarQube Scanner fails". So that it will be possible to disable it.

Hi Linfar, Is this already fixed?

@adakhqan
Copy link

adakhqan commented Dec 9, 2019

I can try to add custom build failure condition enabled by default - something like "Fail the build if SonarQube Scanner fails". So that it will be possible to disable it.

Hello, appreciate if you let us know when the feature is available. It will be very useful for our teams as well. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants