Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression testing with Argos #27

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

shakuzen
Copy link
Contributor

@shakuzen shakuzen commented Nov 2, 2023

In preparation of upgrading a major version of Docusaurus and other dependencies, it would be nice if we can easily identify any visual regressions without manually checking each page with each dependency change. This will upload screenshots to Argos for comparison. Idea from https://docusaurus.io/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing

In preparation of upgrading a major version of Docusaurus and other dependencies, it would be nice if we can easily identify any visual regressions without manually checking each page with each dependency change.
This will upload screenshots to Argos for comparison.
Idea from https://docusaurus.io/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing
@shakuzen shakuzen added the enhancement New feature or request label Nov 2, 2023
Copy link

argos-ci bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 2, 2023, 1:44 PM

@shakuzen
Copy link
Contributor Author

shakuzen commented Nov 2, 2023

Since we are doing yarn install and yarn build in this new GitHub action, I don't think we need the separate "Build pull-request" action (that's essentially all it does). I'll combine them.

Having a separate action was doing a lot of duplicated work.
Instead I've included the steps in the existing actions.
@shakuzen shakuzen merged commit dce9910 into JapanFinance:main Nov 2, 2023
2 checks passed
@shakuzen shakuzen deleted the screenshot-all-the-things branch November 2, 2023 13:49
shakuzen added a commit to shakuzen/JapanFinance.github.io that referenced this pull request Aug 3, 2024
In preparation of upgrading a major version of Docusaurus and other dependencies, it would be nice if we can easily identify any visual regressions without manually checking each page with each dependency change.
This will upload screenshots to Argos for comparison against a reference (the main branch). If a pull request results in visual differences, it will notify us.
Idea from https://docusaurus.io/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant