Skip to content

Commit 90a1f6d

Browse files
committed
Add deprecation warning to ComponentSerializer.toString(Object)
It taking all objects is error-prone, deprecate it and create overloads for used acceptable types.
1 parent ee02d98 commit 90a1f6d

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

chat/src/main/java/net/md_5/bungee/chat/ComponentSerializer.java

+17
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import net.md_5.bungee.api.chat.SelectorComponent;
2121
import net.md_5.bungee.api.chat.TextComponent;
2222
import net.md_5.bungee.api.chat.TranslatableComponent;
23+
import net.md_5.bungee.api.chat.hover.content.Content;
2324
import net.md_5.bungee.api.chat.hover.content.Entity;
2425
import net.md_5.bungee.api.chat.hover.content.EntitySerializer;
2526
import net.md_5.bungee.api.chat.hover.content.Item;
@@ -158,11 +159,27 @@ public static JsonElement toJson(ComponentStyle style)
158159
return gson.toJsonTree( style );
159160
}
160161

162+
/**
163+
* @param object the object to serialize
164+
* @return the JSON string representation of the object
165+
* @deprecated Error-prone, be careful which object you input here
166+
*/
167+
@Deprecated
161168
public static String toString(Object object)
162169
{
163170
return gson.toJson( object );
164171
}
165172

173+
public static String toString(Content content)
174+
{
175+
return gson.toJson( content );
176+
}
177+
178+
public static String toString(JsonElement element)
179+
{
180+
return gson.toJson( element );
181+
}
182+
166183
public static String toString(BaseComponent component)
167184
{
168185
return gson.toJson( component );

0 commit comments

Comments
 (0)