Skip to content

Commit fd4d3b8

Browse files
authored
Merge pull request http4s#1816 from rossabaker/scala-2.12.6
Upgrade to scala-2.12.6, drop macro-compat
2 parents 37435be + 88c679b commit fd4d3b8

File tree

10 files changed

+9
-22
lines changed

10 files changed

+9
-22
lines changed

.appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ environment:
55
TEST_SUITE: test
66
matrix:
77
- SCALA_VERSION: 2.11.12
8-
- SCALA_VERSION: 2.12.4
8+
- SCALA_VERSION: 2.12.6
99

1010
install:
1111
- ps: |

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ env:
1212
matrix:
1313
include:
1414
- jdk: oraclejdk8
15-
scala: 2.12.4
15+
scala: 2.12.6
1616
- jdk: oraclejdk8
1717
scala: 2.11.12
1818
- jdk: oraclejdk9
19-
scala: 2.12.4
19+
scala: 2.12.6
2020
notifications:
2121
webhooks:
2222
urls:

build.sbt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@ lazy val core = libraryProject("core")
2828
fs2Scodec,
2929
http4sWebsocket,
3030
log4s,
31-
macroCompat,
3231
parboiled,
3332
scalaReflect(scalaOrganization.value, scalaVersion.value) % "provided",
3433
scodecBits,
3534
scalaCompiler(scalaOrganization.value, scalaVersion.value) % "provided"
3635
),
37-
macroParadiseSetting
3836
)
3937

4038
lazy val testing = libraryProject("testing")
@@ -45,7 +43,6 @@ lazy val testing = libraryProject("testing")
4543
scalacheck,
4644
specs2Core
4745
),
48-
macroParadiseSetting
4946
)
5047
.dependsOn(core)
5148

@@ -265,7 +262,6 @@ lazy val docs = http4sProject("docs")
265262
circeLiteral,
266263
cryptobits
267264
),
268-
macroParadiseSetting,
269265
description := "Documentation for http4s",
270266
autoAPIMappings := true,
271267
unidocProjectFilter in (ScalaUnidoc, unidoc) := inAnyProject --
@@ -377,7 +373,6 @@ lazy val examplesBlaze = exampleProject("examples-blaze")
377373
description := "Examples of http4s server and clients on blaze",
378374
fork := true,
379375
libraryDependencies ++= Seq(alpnBoot, metricsJson),
380-
macroParadiseSetting,
381376
javaOptions in run ++= (managedClasspath in Runtime).map { attList =>
382377
for {
383378
file <- attList.map(_.data)

core/src/main/scala/org/http4s/QValue.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.http4s
22

33
import cats._
4-
import macrocompat.bundle
54
import org.http4s.internal.parboiled2.{Parser => PbParser}
65
import org.http4s.util.Writer
76
import org.http4s.parser.{AdditionalRules, Http4sParser}
@@ -96,7 +95,6 @@ object QValue extends QValueInstances with QValueFunctions {
9695
/** Exists to support compile-time verified literals. Do not call directly. */
9796
def (thousandths: Int): QValue = new QValue(thousandths)
9897

99-
@bundle
10098
class Macros(val c: Context) {
10199
import c.universe._
102100

core/src/main/scala/org/http4s/Uri.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package org.http4s
33
import cats._
44
import cats.implicits.{catsSyntaxEither => _, _}
55
import java.nio.charset.StandardCharsets
6-
import macrocompat.bundle
76
import org.http4s.Uri._
87
import org.http4s.internal.parboiled2.{Parser => PbParser}
98
import org.http4s.internal.parboiled2.CharPredicate.{Alpha, Digit}
@@ -119,7 +118,6 @@ final case class Uri(
119118
}
120119

121120
object Uri extends UriFunctions {
122-
@bundle
123121
class Macros(val c: Context) {
124122
import c.universe._
125123

docs/src/main/tut/methods.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ Http4s has a list of all the [methods] you're familiar with, and a few more.
99

1010
```tut:book
1111
import cats.effect._
12-
import io.circe.generic._
12+
import io.circe.generic.auto._
1313
import io.circe.syntax._
1414
import org.http4s._, org.http4s.dsl.io._
1515
import org.http4s.circe._
1616
17-
@JsonCodec case class TweetWithId(id: Int, message: String)
18-
@JsonCodec case class Tweet(message: String)
17+
case class TweetWithId(id: Int, message: String)
18+
case class Tweet(message: String)
1919
2020
def getTweet(tweetId: Int): IO[Option[TweetWithId]] = ???
2121
def addTweet(tweet: Tweet): IO[TweetWithId] = ???

docs/src/main/tut/service.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ and calling it with http4s' client.
1010
Create a new directory, with the following build.sbt in the root:
1111

1212
```scala
13-
scalaVersion := "2.12.4" // Also supports 2.11.x
13+
scalaVersion := "2.12.6" // Also supports 2.11.x
1414

1515
val http4sVersion = "{{< version "http4s.doc" >}}"
1616

project/Http4sPlugin.scala

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ object Http4sPlugin extends AutoPlugin {
6161
) ++ signingSettings
6262

6363
override lazy val projectSettings: Seq[Setting[_]] = Seq(
64-
scalaVersion := (sys.env.get("TRAVIS_SCALA_VERSION") orElse sys.env.get("SCALA_VERSION") getOrElse "2.12.4"),
64+
scalaVersion := (sys.env.get("TRAVIS_SCALA_VERSION") orElse sys.env.get("SCALA_VERSION") getOrElse "2.12.6"),
6565

6666
// Rig will take care of this on production builds. We haven't fully
6767
// implemented that machinery yet, so we're going to live without this
@@ -227,9 +227,6 @@ object Http4sPlugin extends AutoPlugin {
227227
}
228228
}
229229

230-
val macroParadiseSetting =
231-
libraryDependencies += compilerPlugin("org.scalamacros" % "paradise" % "2.1.1" cross CrossVersion.full)
232-
233230
def latestPerMinorVersion(file: File): Map[(Int, Int), Version] =
234231
JGit(file).tags.collect {
235232
case ref if ref.getName.startsWith("refs/tags/v") =>
@@ -285,7 +282,6 @@ object Http4sPlugin extends AutoPlugin {
285282
lazy val jspApi = "javax.servlet.jsp" % "javax.servlet.jsp-api" % "2.3.1" // YourKit hack
286283
lazy val log4s = "org.log4s" %% "log4s" % "1.6.1"
287284
lazy val logbackClassic = "ch.qos.logback" % "logback-classic" % "1.2.3"
288-
lazy val macroCompat = "org.typelevel" %% "macro-compat" % "1.1.1"
289285
lazy val metricsCore = "io.dropwizard.metrics" % "metrics-core" % "4.0.2"
290286
lazy val metricsJson = "io.dropwizard.metrics" % "metrics-json" % metricsCore.revision
291287
lazy val prometheusClient = "io.prometheus" % "simpleclient_common" % "0.3.0"

testing/src/test/scala/org/http4s/illTyped.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ object illTyped {
3131
def apply(code: String, expected: String): Unit = macro IllTypedMacros.applyImpl
3232
}
3333

34-
@macrocompat.bundle
3534
class IllTypedMacros(val c: whitebox.Context) {
3635
import c.universe._
3736

website/src/hugo/content/changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ ordered chronologically, so each release contains all changes described below
99
it.
1010

1111
# v0.18.10-SNAPSHOT
12+
* Eliminate dependency on Macro Paradise and macro-compat [#1816](https://github.com/http4s/http4s/pull/1816)
1213
* Dependency upgrades:
1314
* cats-effect-0.10.1
1415
* fs2-0.10.4

0 commit comments

Comments
 (0)