Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing space in default Git icon definitions leads to link-ified whitespace in default config/profile #6112

Open
ethanherbertson opened this issue Jan 22, 2025 · 0 comments

Comments

@ethanherbertson
Copy link

I recently installed Oh My Posh on a fresh laptop and am very impressed with the default segment definitions, and especially the Git segment's link to the repo when you click on the icon. Very cool!

However, by default the icons for GitHub/GitLab/etc are all defined with a trailing space. I know that's a common practice in a lot of OMP scenarios, but for icon definitions it means that a lot of segment definitions will end-up with an extra trailing space (if the authors not thinking).

More to the point, the default configuration looks ever so slightly janky to me, because of that extra space being both (a) extra and (b) link-ified:

Image

I think more good than harm would come from removing the trailing spaces from those default definitions. (They're not documented to be there, anyway.)

See

"github": {GithubIcon, "\uF408 "},
"gitlab": {GitlabIcon, "\uF296 "},
"bitbucket": {BitbucketIcon, "\uF171 "},
"dev.azure.com": {AzureDevOpsIcon, "\uEBE8 "},
"visualstudio.com": {AzureDevOpsIcon, "\uEBE8 "},
"codecommit": {CodeCommit, "\uF270 "},
"codeberg": {CodebergIcon, "\uF330 "},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant