You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently installed Oh My Posh on a fresh laptop and am very impressed with the default segment definitions, and especially the Git segment's link to the repo when you click on the icon. Very cool!
However, by default the icons for GitHub/GitLab/etc are all defined with a trailing space. I know that's a common practice in a lot of OMP scenarios, but for icon definitions it means that a lot of segment definitions will end-up with an extra trailing space (if the authors not thinking).
More to the point, the default configuration looks ever so slightly janky to me, because of that extra space being both (a) extra and (b) link-ified:
I think more good than harm would come from removing the trailing spaces from those default definitions. (They're not documented to be there, anyway.)
I recently installed Oh My Posh on a fresh laptop and am very impressed with the default segment definitions, and especially the Git segment's link to the repo when you click on the icon. Very cool!
However, by default the icons for GitHub/GitLab/etc are all defined with a trailing space. I know that's a common practice in a lot of OMP scenarios, but for icon definitions it means that a lot of segment definitions will end-up with an extra trailing space (if the authors not thinking).
More to the point, the default configuration looks ever so slightly janky to me, because of that extra space being both (a) extra and (b) link-ified:
I think more good than harm would come from removing the trailing spaces from those default definitions. (They're not documented to be there, anyway.)
See
oh-my-posh/src/segments/git.go
Lines 580 to 586 in 09e5b18
The text was updated successfully, but these errors were encountered: