Replies: 2 comments
-
Dear @overcrook |
Beta Was this translation helpful? Give feedback.
-
OK, I'll prepare a PR soon, first I need to clean up the code a bit. |
Beta Was this translation helpful? Give feedback.
-
Dear @overcrook |
Beta Was this translation helpful? Give feedback.
-
OK, I'll prepare a PR soon, first I need to clean up the code a bit. |
Beta Was this translation helpful? Give feedback.
-
Hello @JafarAkhondali , thanks for this repo and for useful videos!
I have a Nitro AN17-41, which has a "mode" button instead of "turbo" button. In Windows, this button doesn't just toggle Turbo mode, it actually loops through some predefined modes, such as:
Specifically, when AC is connected, this button cycles between Quiet -> Balanced -> Performance -> Turbo, and when AC is disconnected, it goes Eco -> Balanced.
I looked at this driver in mainline and found that such a feature already exists for Predator v4 Sense. It looks like my Nitro laptos uses the same WMI methods.
So I locally merged your version of this driver with the upsream one and additionaly patched it to support my laptop. And now it works, I can successfully switch between these modes!
I assume this new method will work for all recent Predator and Nitro laptops as well.
So here is the question. Do you plan to rebase your driver to mainline version? In that case, I can just wait and then create a PR with only the relevant changes. Or, I can create a PR to backport all the new features from upstream and include my patches for my laptop in that PR.
In any case, I plan to submit my patch for the mainline, but since this will be my first public patch for the Linux I have no idea when/if it will be applied.
Beta Was this translation helpful? Give feedback.
All reactions