Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off of ng2-cookies #39

Open
JackMorrissey opened this issue Mar 28, 2021 · 0 comments
Open

Migrate off of ng2-cookies #39

JackMorrissey opened this issue Mar 28, 2021 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@JackMorrissey
Copy link
Owner

Migrate from ng2-cookies

After upgrading to Angular 11 I'm seeing

Warning: beyond-rule-4\src\app\ynab-api\ynab-api.service.ts depends on 'ng2-cookies'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Since upgrading to Angular 11 killed IE 11 support anyways, we can probably just do this the simple way without a library.
@JackMorrissey JackMorrissey added the dependencies Pull requests that update a dependency file label Mar 28, 2021
@JackMorrissey JackMorrissey changed the title ng2-cookies Migrate off of ng2-cookies Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackMorrissey