Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update Library does not remove items that have been removed from library #214

Open
Ronald-Diemicke opened this issue Dec 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Ronald-Diemicke
Copy link

Describe the bug

I'd expect that 'update library' doesn't just add new things, but also removes them if they've been removed from the library on the file system...

Steps To Reproduce

Steps to reproduce the behavior:

  1. Add an item to the library
  2. Use 'Update Library'
  3. Remove the item on the file system
  4. Use 'Update Library' again - notice that the item remains in retrom

Expected behavior

I'd expect that that something called 'update library' would make the system match the data of the file system; if this isn't the case, maybe renaming this button to 'scan library for new items' would be more accurate. Would be nice to have a way to have it 'clean up' based on the state of the file system.

@Ronald-Diemicke Ronald-Diemicke added the bug Something isn't working label Dec 30, 2024
@JMBeresford
Copy link
Owner

Not a bug, simply not implemented yet. This is something I have deferred as I think it will be more easily resolved once I implement versioning/updates of game entries ( e.g. file changes in a game's directory constitutes an new version, clients will be prompted to update their installed copy ).

@JMBeresford JMBeresford added enhancement New feature or request and removed bug Something isn't working labels Dec 30, 2024
@Ronald-Diemicke Ronald-Diemicke changed the title Bug: Update Library does not remove items that have been removed from library Feature: Update Library does not remove items that have been removed from library Dec 30, 2024
@Ronald-Diemicke
Copy link
Author

Not a bug, simply not implemented yet. This is something I have deferred as I think it will be more easily resolved once I implement versioning/updates of game entries ( e.g. file changes in a game's directory constitutes an new version, clients will be prompted to update their installed copy ).

Ehhhh... this could be dangerous in and of itself...I'm not sure if versioning the install file is the right way to go or maybe you have a 'sub-folder' structure for patches that read the filenames to know what versions are available? Typically - you don't reinstall the whole game to get a patch... you could also have the base install have a version number (in the case of repacks). Could also do the same thing with a sub-folder for DLC, addons, mods, ect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants