-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleeping and retrying for a long time #185
Comments
@valankar Tbh that was sort of a hack to work around the random errors yahoo finance was returning. When I implemented this, it was an effective way of brute forcing a response. I'm waiting for Yahoo Finance to become more stable before I completely refactor this library. I suspect they are in the middle of a tech stack overhaul similar to 2017's. If you have a more effective manner to handle this, I'll be more than happy to review and merge in a PR. I'm slammed with work and won't be able to really address anything on my end until April. |
I was getting some long hangs in my script and it boiled down to:
yahoofinancials/yahoofinancials/data.py
Line 565 in 2f2cc6c
This is retrying a sleep in a loop for 250 times. I'm not sure why 250 was chosen, but could there be an option to disable this or provide a limit to the timeout?
I see there is a timeout option:
yahoofinancials/yahoofinancials/yf.py
Line 67 in 2f2cc6c
but it doesn't seem to apply here?
The text was updated successfully, but these errors were encountered: