[MP] Hoist anti fakeplayer code into engine #1205
Open
+41
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razish
changed the title
- replace g_antiFakePlayer -> sv_antiFakePlayer (1, 2) - replace g_maxConnPerIP -> sv_maxConnPerIP
Razish
force-pushed
the
hoist-anti-fakeplayer
branch
from
6324778
to
bf4eb9d
Compare
|
As far as I understand the problem in Issue #1146 , wouldn't it also work to make sure IPstring is purged on disconnect? What would make the solution here better? |
If it was cleared in game module that might be fine. If in server, not so good. It'd be nice to solve this in a way that doesn't require an engine update. That said, this is a nice and long overdue cleanup of the code either way and certainly can't hurt. Also, is it possible that the ip is not deleted in order to detect reconnets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed connection status checks in
g_antiFakePlayer.Replicated the check in the engine.
g_antiFakePlayer->sv_antiFakePlayerg_maxConnPerIP->sv_maxConnPerIPFixes #1146