Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost Signature #71

Open
FroztIkon opened this issue Jan 21, 2025 · 4 comments
Open

Ghost Signature #71

FroztIkon opened this issue Jan 21, 2025 · 4 comments

Comments

@FroztIkon
Copy link

Running:
Ubuntu 22
Ghost 5.98.1
Ghosler 0.98.4

Start off with, I made an adjustment to Ghosler per #54. However, new issue cropped up in the error log with no further information in the mail server logs, so no mail/newsletter was sent. Here's the error:
[ERROR] => Express: The signature in the 'X-Ghost-Signature' header is not valid.

Not sure where to find any other relevant information to give.

@ItzNotABug
Copy link
Owner

Hey 👋,
Its an old PR and the signature issue was fixed on a later version. See -

  1. https://github.com/ItzNotABug/ghosler/releases/tag/0.98.2
  2. Fix Signature Checks #66
  3. Ghost 5.87.1 Signature Checks #65

Update your source and it should be fine.

@FroztIkon
Copy link
Author

Hey 👋, Its an old PR and the signature issue was fixed on a later version. See -

  1. https://github.com/ItzNotABug/ghosler/releases/tag/0.98.2
  2. Fix Signature Checks #66
  3. Ghost 5.87.1 Signature Checks #65

Update your source and it should be fine.

Thanks for the quick reply. I've updated my ghost now to 5.107.2

Maybe I'm having a dense moment, but when I followed the install instructions for ghosler, it installs 0.98.4, which should have the [Fix Signature Checks #66] in it, since it's .2 releases after?

And as an added bonus to my confusion, which source should I update?

@ItzNotABug
Copy link
Owner

ItzNotABug commented Jan 21, 2025

@FroztIkon you mentioned -

Start off with, I made an adjustment to Ghosler per #54

So did you fork that branch, or made changes to your local Ghosler instance?

If you started with the latest Ghosler source, it should not throw - X-Ghost-Signature errors if you have correctly setup the webhook on Ghost settings.

Thanks.

@FroztIkon
Copy link
Author

FroztIkon commented Jan 21, 2025

The only change I have made to ghosler (no forks) was after install

ahhhhh you hardcoded it to use secure transport

ghosler/utils/mail/mailer.js

Line 192 in 244575e

secure: true,

Changed that to false. On a side note, because it wasn't listed in the instructions, I clicked the
Click to Generate Secret Key
in the settings, after I had everything filled out, then save at the bottom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants