Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling custom domains #7

Open
IoIxD opened this issue Sep 15, 2022 · 1 comment
Open

Handling custom domains #7

IoIxD opened this issue Sep 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@IoIxD
Copy link
Owner

IoIxD commented Sep 15, 2022

The current solution if somebody wants to bind a custom domain to their server listing is to just use php_get_contents or js fetch to fetch the contents of the site. This works somewhat, but what would be better is if you could do guildID.dfs.ioi-xd.net, and expect it to work the same as dfs.ioi-xd.net/guildID/.... Then, you could have your custom domain be a CNAME to that.

The code should be updated to handle both /guildID/... and guildID.dfs...

@IoIxD IoIxD mentioned this issue Sep 15, 2022
7 tasks
@IoIxD IoIxD added the to-do label Sep 16, 2022
@IoIxD IoIxD changed the title Handling sub-subdomains Handling custom subdomains Sep 16, 2022
@IoIxD
Copy link
Owner Author

IoIxD commented Sep 16, 2022

when a site cnames to another site, the first url gets passed to the request, not the second. so we'd have to have a server configure their domain through the bot anyways so we can handle it.

so there's no point in a new subdomain, or working with wildcard certificates. we should just have the user cname to dfs.ioi-xd.net and then have the code handle whatever domain the server configures.

@IoIxD IoIxD changed the title Handling custom subdomains Handling custom domains Sep 16, 2022
@IoIxD IoIxD added this to the 1.3 milestone Oct 16, 2022
@IoIxD IoIxD modified the milestones: 1.3, 1.5.0 Nov 24, 2022
@samhza samhza added enhancement New feature or request and removed to-do labels Jan 22, 2023
@IoIxD IoIxD removed this from the 1.4.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants